- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
tools: bump remark-cli to 4.0 #17028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | /CC @nodejs/documentation @wooorm | 
              
                    cjihrig
  
              
              approved these changes
              
                  
                    Nov 14, 2017 
                  
              
              
            
            
              
                    watilde
  
              
              approved these changes
              
                  
                    Nov 14, 2017 
                  
              
              
            
            
              
                    jasnell
  
              
              approved these changes
              
                  
                    Nov 16, 2017 
                  
              
              
            
            
              
                    gibfahn
  
              
              approved these changes
              
                  
                    Nov 16, 2017 
                  
              
              
            
            
| Landed in 66e2751 | 
    
  addaleax 
      pushed a commit
      that referenced
      this pull request
    
      Nov 18, 2017 
    
    
      
  
    
      
    
  
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Dec 12, 2017 
    
    
      
  
    
      
    
  
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
      
     Merged
  
| Leaving to bake until remark-cli is stable on master, and these can all be backported together to v8.x | 
    
  MylesBorins 
      pushed a commit
      that referenced
      this pull request
    
      Aug 17, 2018 
    
    
      
  
    
      
    
  
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools